On 21/08/13 05:15, Vincent Bernat wrote: > > Hi Scott! Hi Vincent, thanks for reviewing my package! > > The package seems fine for me. I just noticed those minor details: > > - debian/changelog: the "Imported Upstream version xxxx" line is > useless, please remove it. Fixed. > - debian/control: do not start the short description with a capital. Fixed. > - debian/rules: debhelper 9 is doing hardening by default now, so you > don't need to depend on hardening-wrapper and set the option in > debian/rules. Maybe you did try and this doesn't work? > I'm not sure if debhelper was doing hardening by default when I originally packaged compton - hence the wrapper dependency. Removing the dependency didn't work initially due to the Makefile ignoring CPPFLAGS. I've patched the issue, and hardening is now working without the wrapper dependency. The package has been re-uploaded to mentors if you would like to take a look :) -- Regards, Scott Leggett.
Attachment:
signature.asc
Description: OpenPGP digital signature