❦ 19 août 2013 07:57 CEST, Tom Lee <debian@tomlee.co> : > Also incorporated part of an upstream patch for another potential, > seemingly unrelated memory corruption issue that didn't quite make the > 0.2.0 release. > > Let me know if you still can't build from source with these two changes in > place. OK, it works for me too. > I've also explicitly removed the .symbols file as I found the Policy Manual > explicitly talks about C++ libraries in the last paragraph of section 8.6 ( > http://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-depends > ): Please add a lintian override for this: libcapnp-0.2.0: no-symbols-control-file usr/lib/libcapnp-0.2.0.so > Last of all, I've just built & uploaded a new build of 0.2.0-1 with the > changes you suggested in your original review, plus the changes discussed > in this email: > > http://mentors.debian.net/debian/pool/main/c/capnproto/capnproto_0.2.0-1.dsc > > Thanks! Please let me know if I can do anything else to move this forward. So, a few other comments: - Remove the comments at the top of debian/rules, they clutter it and they do not match the content (since you are using the tiny debhelper set). Don't even keep the DH_VERBOSE stuff - The hardening stuff does not seem to work correctly. Maybe you could just try with debhelper 9 and debian/compat to 9 to have them apply automatically. - Use DEP3 (http://dep.debian.net/deps/dep3/) to describe the patchs that you add (with Author, Description and Forwarded fields). - You ship the .la file and empty the dependency_libs field. I think that you can just not ship it at all. There was a release goal to remove them. Since you don't have any reverse dependency, it is better to not ship it. - You use --with python2. I don't see any Python files in the resulting packages. Therefore, you don't need to use dh_python2. I suppose Python is only used in tests. Just keep it as a Build-Depends. - In debian/control, don't start the short description with a capital for capnproto. Everything else seems OK. -- /* * Hash table gook.. */ 2.4.0-test2 /usr/src/linux/fs/buffer.c
Attachment:
signature.asc
Description: PGP signature