Bug#712026: transcriber review

[Giulio Paci <giuliopaci@gmail.com>]

Il 11/08/2013 19:47, Paul Wise ha scritto:
> A review:
> 
> Blockers:
> 
> The changes to debian/copyright_hints look weird, could you explain?

I do not understand what you mean.
The whole content of debian/copyright_hints usually looks weird to me, but it is useful to:
1) write debian/copyright from scratch;
2) being notfied that new files exists or that copyright information changed.

> licensecheck complains during the build process about this.

The problem was that generated copyright_hints before applying all the patches, while at build time licensecheck is run after applying all the patches.
I just regenerated the file.

> 1005_avoid_to_put_transcriber_in_background.patch looks wrong, the case
> you patched is explicitly about putting the program in the background.

This was explicitly requested and I agreed with the person making the request.
I see no point always putting transcriber in background when it is so easy to write "transcriber &" when needed.
Despite the name of the variable "bg", its purpose is to detect if the program should be run in batch mode or in interactive mode.
Upstream decided that interactive mode implies not only the use of wish instead of tclsh, but also to always start transcriber in background.

> Things that might be nice to fix one day:
> 
> Please include the .desktop file, icon, manual page and patches
> upstream.

I already started sending some of the patches upstream, but I have not yet received an answer yet.

> You might want to wrap debian/menu one item per line.

Done.

> Is debian/dirs still needed?

No it is not. I just dropped the file.

> Automated checks:
> 
> https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package

Thank you for pointing it.

> cdbs:
> 
> /usr/share/cdbs/1/rules/buildcore.mk:109: WARNING:  DEB_DH_INSTALL_ARGS is a deprecated variable

I do not think it is possible to solve this in transcriber. Am I wrong?

> cme:
>
> Warning in 'patches:"1008_update_contacts_and_urls.patch" Synopsis' value 'updates contacts and references information in program messages': Synopsis is too long.
> Warning in 'patches:"1009_update_contacts_and_urls_in_doc.patch" Synopsis' value 'updates contacts and references information in program documentation': Synopsis is too
long.

> Warning in 'copyright Format' value 'http://www.debian.org/doc/copyright-format/1.0': Format does not match the recommended URL for DEP-5

Fixed.


> suspicious-source:
>
> demo/know.sph appears to be a text file with a bunch of binary junk appended to the end?

The sphere audio format is designed to cheat text editors: the header is 1024 bytes long and is plain ascii, so that most text editors will open the file as text.
So it is not a text file, but a binary one.

> desktop-file-validate:
>
> ./debian/transcriber.desktop: error: value "Audio;AudioVideo" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
> ./debian/transcriber.desktop: error: value "application/wav" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Fixed.

> xmllint:
>
> ./doc/en/sample.xml:19: parser error : Input is not proper UTF-8, indicate encoding !
> Bytes: 0xFB 0x72 0x20 0x3F
>         s�r ?
>          ^

Fixed.


Unless any of the following is blocker, I prefer to fix/decide to not fix them later.

> cme:
>
> Warning in 'control source Build-Depends:3' value 'debhelper (>= 9~)': should be (>= 9) not (>= 9~) because compat is 9
>
> gcc:
> 
> lots of warnings, please send upstream.
> 
> dpkg-shlibdeps:
> 
> dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/transcriber/usr/lib/tcltk/transcriber1.5/libtrans.so was not linked against libdl.so.2 (it uses none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/transcriber/usr/lib/tcltk/transcriber1.5/libtrans.so was not linked against libpthread.so.0 (it uses none of the library's symbols)
> 
> uscan:
> 
> Newest version on remote site is 1.5.1, local version is 1.5.1.1
>  => remote site does not even have current version
>
> lintian:
> 
> P: transcriber: no-upstream-changelog
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/refFrame.html usr/share/doc/transcriber/html/fr/refFrame.html
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/pause.bmp usr/share/doc/transcriber/html/img/pause.bmp
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/userMenu.html usr/share/doc/transcriber/html/fr/userMenu.html
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/play.bmp usr/share/doc/transcriber/html/img/play.bmp
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/info.bmp usr/share/doc/transcriber/html/img/info.bmp
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/userFrame.html usr/share/doc/transcriber/html/fr/userFrame.html
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/backward.bmp usr/share/doc/transcriber/html/img/backward.bmp
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/fr/pencil.gif usr/share/doc/transcriber/html/img/pencil.gif
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/previous.bmp usr/share/doc/transcriber/html/img/previous.bmp
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/fr/tete.gif usr/share/doc/transcriber/html/img/tete.gif
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/forward.bmp usr/share/doc/transcriber/html/img/forward.bmp
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/next.bmp usr/share/doc/transcriber/html/img/next.bmp
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/about.html usr/share/doc/transcriber/html/fr/about.html
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/gpl.html usr/share/doc/transcriber/html/fr/gpl.html
> X: transcriber: duplicate-files usr/share/doc/transcriber/html/de/transblue.gif usr/share/doc/transcriber/html/img/transblue.gif
> 
> blhc:
> 
> CFLAGS missing (-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security): x86_64-linux-gnu-gcc -O -fPIC -I/usr/include/tcl8.4/tcl-private/generic -I/usr/include/tcl8.4/tk-private/generic -I/usr/include -I/usr/include -DTCL_81_API -D_FORTIFY_SOURCE=2  -c -o axis.o axis.c
> CFLAGS missing (-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security): x86_64-linux-gnu-gcc -O -fPIC -I/usr/include/tcl8.4/tcl-private/generic -I/usr/include/tcl8.4/tk-private/generic -I/usr/include -I/usr/include -DTCL_81_API -D_FORTIFY_SOURCE=2  -c -o wavfm.o wavfm.c
> CFLAGS missing (-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security): x86_64-linux-gnu-gcc -O -fPIC -I/usr/include/tcl8.4/tcl-private/generic -I/usr/include/tcl8.4/tk-private/generic -I/usr/include -I/usr/include -DTCL_81_API -D_FORTIFY_SOURCE=2  -c -o segmt.o segmt.c
> CFLAGS missing (-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security): x86_64-linux-gnu-gcc -O -fPIC -I/usr/include/tcl8.4/tcl-private/generic -I/usr/include/tcl8.4/tk-private/generic -I/usr/include -I/usr/include -DTCL_81_API -D_FORTIFY_SOURCE=2  -c -o trans.o trans.c
> 
> 
> isutf8:
> 
> ./demo/know.sph: line 40, char 1, byte offset 689: invalid UTF-8 code
> ./demo/frint980428.trs: line 18, char 1, byte offset 3: invalid UTF-8 code
> ./tcl/Spelling.tcl: line 94, char 1, byte offset 44: invalid UTF-8 code
> ./tcl/Speaker.tcl: line 681, char 1, byte offset 8: invalid UTF-8 code
> ./convert/stm.tcl: line 7, char 1, byte offset 89: invalid UTF-8 code
> ./etc/local_pt.txt: line 10, char 1, byte offset 21: invalid UTF-8 code
> ./etc/local_fr.txt: line 10, char 1, byte offset 7: invalid UTF-8 code
> ./etc/default.txt: line 155, char 1, byte offset 21: invalid UTF-8 code
> ./doc/fr/present_local.html: line 24, char 1, byte offset 24: invalid UTF-8 code
> ./doc/fr/frame_local.html: line 6, char 1, byte offset 13: invalid UTF-8 code
> ./doc/fr/gpl.html: line 4, char 1, byte offset 28: invalid UTF-8 code
> ./doc/fr/user.html: line 12, char 1, byte offset 28: invalid UTF-8 code
> ./doc/fr/menu_local.html: line 16, char 1, byte offset 75: invalid UTF-8 code
> ./doc/fr/refFrame.html: line 6, char 1, byte offset 22: invalid UTF-8 code
> ./doc/fr/reference.html: line 910, char 1, byte offset 85: invalid UTF-8 code
> ./doc/de/gpl.html: line 4, char 1, byte offset 28: invalid UTF-8 code
> ./doc/de/menu_local.html: line 15, char 1, byte offset 75: invalid UTF-8 code
> ./doc/de/refFrame.html: line 6, char 1, byte offset 22: invalid UTF-8 code
> ./doc/de/menu_web.html: line 28, char 1, byte offset 52: invalid UTF-8 code
> ./doc/de/frame_web.html: line 6, char 1, byte offset 13: invalid UTF-8 code
> ./doc/en/menu_local.html: line 16, char 1, byte offset 75: invalid UTF-8 code
> ./doc/en/sample.xml: line 19, char 1, byte offset 10: invalid UTF-8 code
> ./debian/patches/1001_pt_localization_file.patch: line 22, char 1, byte offset 22: invalid UTF-8 code
> ./debian/patches/1011_tidify_html.patch: line 60, char 1, byte offset 14: invalid UTF-8 code
> ./debian/copyright_hints: line 221, char 1, byte offset 11: invalid UTF-8 code
> 
> fdupes:
> 
> ./doc/img/next.bmp
> ./img/next.bmp
> ./doc/de/next.bmp
> 
> ./doc/img/previous.bmp
> ./img/previous.bmp
> ./doc/de/previous.bmp
> 
> ./doc/img/transblue.gif
> ./doc/de/transblue.gif
> 
> ./doc/img/play.bmp
> ./img/play.bmp
> ./doc/de/play.bmp
> 
> ./doc/img/backward.bmp
> ./img/backward.bmp
> ./doc/de/backward.bmp
> 
> ./doc/img/pause.bmp
> ./img/pause.bmp
> ./doc/de/pause.bmp
> 
> ./doc/img/forward.bmp
> ./img/forward.bmp
> ./doc/de/forward.bmp
> 
> ./doc/img/info.bmp
> ./img/info.bmp
> ./doc/de/info.bmp
> 
> ./doc/fr/pencil.gif
> ./doc/img/pencil.gif
> 
> ./doc/fr/about.html
> ./doc/de/about.html
> 
> ./doc/fr/refFrame.html
> ./doc/de/refFrame.html
> 
> ./doc/fr/userMenu.html
> ./doc/de/userMenu.html
> 
> ./doc/fr/gpl.html
> ./doc/de/gpl.html
> 
> ./doc/fr/userFrame.html
> ./doc/de/userFrame.html
> 
> ./doc/fr/tete.gif
> ./doc/img/tete.gif
> 
> ./img/over2.bmp
> ./img/over1.bmp
>