[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#717577: RFS: engauge-digitizer/5.1-1



Hi Tobias,

Thanks for working towards updating this package. (I don't intend to sponsor 
upload of this package.)

Just a couple of brief comments:

>   * New upstream release (Closes: #716732)

the new source tarball is about twice the size of the old one because it 
contains precompiled and automatically generated objects:

	engauge-digitizer-5.1/Makefile
	engauge-digitizer-5.0/bin/engauge

I wonder if it would be worth repacking the tarball at this stage (it's 
certainly worth prodding upstream to not include automatically generated files 
in the source tarballs.

>   * Moved to cdbs

I don't want to deal with cdbs so I'm afraid that's where I stopped reviewing 
this package and why I won't be uploading it. Sorry to be so blunt but that's 
how it is with cdbs. Note that you could have simplified debian/rules using 
debhelper version 7 or later, which is much more widely understood.

regards
Stuart

-- 
Stuart Prescott    http://www.nanonanonano.net/   stuart@nanonanonano.net
Debian Developer   http://www.debian.org/         stuart@debian.org
GPG fingerprint    BE65 FD1E F4EA 08F3 23D4 3C6D 9FE8 B8CD 71C5 D1A8
GPG fingerprint    90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7


Reply to: