[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#714947: RFS: djvusmooth/0.2.14-1 -- graphical editor for DjVu



Hi Daniel,

I found only few pedantic issues... :)

`cme check dpkg-control` report the following unnecessary versioned
dependencies:

 * python-all (>= 2.6.6-3~)
   Debian has squeeze -> 2.6.6-3+squeeze7; wheezy -> 2.7.3-4; jessie -> 2.7.5-2; sid -> 2.7.5-2;
 * djvulibre-bin (>= 3.5.20-5~)
   Debian has squeeze -> 3.5.23-3; wheezy -> 3.5.25.3-1; jessie -> 3.5.25.3-3; sid -> 3.5.25.4-1;
 * python-djvu (>= 0.1.15)
   Debian has squeeze -> 0.1.18-2; wheezy -> 0.3.9-1; jessie -> 0.3.9-1; sid -> 0.3.9-1; sid -> 0.3.9-1+b1;

This time let's remove them before upload please.

On Fri, 5 Jul 2013 01:08:20 Daniel Stender wrote:
>   * Bumped Debhelper level to 8 (deb/control and compat).

Why only to level 8? Current recommended level is 9 and even if you're
backporting to squeeze-backports debhelper 9 is there.
Any particular reason to stay on compat=8?

I know Arch:all packages benefit little from upgrade from dh-8 to dh-9
but personally I would upgrade for the sake of staying
up-to-date. IMHO there are less caveats if you maintain all/most of
your packages in same DH compatibility level...

Another improvement idea might be to use upstream .desktop file from
"extra/". There are few differences from .desktop file in "debian/"
and perhaps they could be merged with patch. Usually it is better to
use upstream files when possible as it help to track changes and share
our improvements as well as reduce duplication.

Please advise if you want to address any of the above issues before
upload. Thanks.

Cheers,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B


Reply to: