[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#710473: RFS: bats/0.2.0-1



(I don't intend to sponsor this package. Sorry!)

* Grzegorz Niewisiewicz <grzegorz@niewisiewicz.pl>, 2013-06-16, 22:30:
http://mentors.debian.net/package/bats

Direct link to .dsc for the lazy:
http://mentors.debian.net/debian/pool/main/b/bats/bats_0.2.0-1.dsc

Machine-readable d/copyright file specification reads: "There are many versions of the MIT license. Please use Expat instead, when it matches."

Lintian emits:
O: bats source: package-needs-versioned-debhelper-build-depends 9
W: bats source: out-of-date-standards-version 3.9.3 (current is 3.9.4)

But wait, why did you override package-needs-versioned-debhelper-build-depends? Lintian is correct here: your build-dependency on debhelper is insufficient.

If Lintian was a bit smarter, it would also emit hyphen-used-as-minus-sign for this line:
.RI [ -c ] " file" ...

Your README.source reads: "You WILL either need to modify or delete this file". So please do one of these things (probably the latter).

The .orig.tar uploaded to mentors is not the same as uscan downloads: files in the former are owned by grn:grn; they are owned by root:root in the latter.

Please remove the "Sample debian/rules that uses debhelper..." comment. It doesn't make sense.

Please honour DEB_BUILD_OPTIONS=nocheck.

I don't see a point of putting obvious things like "Added a watch file" to a changelog entry for an initial release. (Now if there was already a version in the archive without d/watch, and the file was added in a new version, that'd be another story.)

Why does it need such a new version of coreutils? (This, on the other hand, might be something worth explaining in the changelog.) This build-dependency makes the package unbuildable on i386, which is stuck with an earlier version of coreutils.

Also, why does it need such a new version of bash?

Why priority "extra"? I'd use "optional".

--
Jakub Wilk


Reply to: