Control: tags -1 moreinfo
Hi Daniel,
Thanks for packaging "scantailor".
I had a brief look at the package and IMHO it needs a little bit more
work before we'll be able to upload it.
* buildflags.patch is incorrect because it is hardcoding FLAGS.
To make it useful upstream you could modify cmake to avoid
overriding CXXFLAGS and then pass build flags like in the following
example:
override_dh_auto_configure:
dh_auto_configure -- \
-DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
-DCMAKE_CXX_FLAGS_RELWITHDEBINFO="$(CPPFLAGS)" \
-DCMAKE_EXE_LINKER_FLAGS=" -Wl,--as-needed $(LDFLAGS)"
Also perhaps more DEP-3 headers like [Forwarded,Last-Update] may be
useful.
* Passing build flags requires more work as there are still some
FLAGS missing, according to `blhc`:
CXXFLAGS missing (-fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security)
* I: scantailor: unused-override hardening-no-fortify-functions usr/bin/scantailor-cli
* Please do not override "no-upstream-changelog". Lack of upstream
changelog is a genuine (minor) problem isn't it? Silencing
legitimate warnings is not a good idea, especially when you do it
without corresponding comment about why the warning was suppressed
in lintian-overrides.
* regarding copyright, notation "Files: ./crash_reporter/google-breakpad/*"
is a bit strange as there is no need to prefix file paths with "./"
* In "Copyright: 2006-2008 Google Inc." paragraph license "other"
is incorrect -- it is a "BSD-2-clause" license.
* In "Copyright: 2005-2007 Paul Hsieh" paragraph license "other" is
incorrect -- it looks like modified "BSD-3-clause" license, so
perhaps it might be better to mark it something like
"BSD-3-clause(modified)" and/or add a comment.
All the best,
Dmitry Smirnov
GPG key : 4096R/53968D1B
---
No person, no idea, and no religion deserves to be illegal to insult,
not even the Church of Emacs.
-- Richard Stallman
Attachment:
signature.asc
Description: This is a digitally signed message part.