[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697627: RFS: gogglesmm/0.12.7-1



Hi,

I made some changes to the package which can be found here:


http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.7-1.dsc

Am Sonntag, den 02.06.2013, 23:54 +0200 schrieb Sebastian Ramacher:
> On 2013-01-07 20:19:36, Hendrik Rittich wrote:
> >   dget -x http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.7-1.dsc
> 
> The change of Standards-Version is not documented in the changelog. Some of
> the changes to debian/rules are not documented either.
This should be corrected.

> Why are you only using the hardening flags from CPPFLAGS and LDFLAGS but not
> the ones from C(XX)FLAGS? Additionally, DEB_BUILD_OPTIONS=noopt doesn't
> work anymore.
That was my mistake. I used the wrong variable. Should be fixed.

> There also many useless dependency warnings from dh-shlibdeps. Please
> get these fixed.
Those libraries are linked due to pkg-config configuration files. These
libraries are all dependencies of the libfox-1.6-0 package. Since
gogglesmm depends on libfox those dependencies are needed anyways.
Therefore I think there is no reason for removing these direct
dependencies.

> Why does the clean target run dh_testroot?
I removed that.

> lintian emits:
> 
> P: gogglesmm source: duplicate-in-relation-field in source build-depends: libdbus-1-dev, libdbus-1-dev
> P: gogglesmm source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5
> W: gogglesmm source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
> 
> Please fix these.
This should be fixed.

> lintian also emits:
> 
> I: gogglesmm: desktop-entry-lacks-keywords-entry usr/share/applications/gogglesmm.desktop
> 
> Please forward this issue upstream and get it fixed there.
Done.

I hope that fixes the issues with the package. Thank you for your time.

Regards,

Hendrik



Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: