Bug#706361: gti review

[Dmitry Smirnov <onlyjob@member.fsf.org>]

Hello Felix,

Thank you for your corrections. We're almost there, but I hope that
few more pedantic issues could be fixed... :)


> I take it it is not customary to provide overrides for "pedantic"
> warnings?

You can do it and on some occasions I overridden some pedantic
warnings to acknowledge that I've had a look at it and no further
action is necessary. I found overrides useful with maintaining many
packages where I tend to forget whenever I already dealt with the
warning in particular package.

But it is important to recognise unnecessary overrides such as those
that tell you about problems that can be addressed by you or by
upstream developer(s). It is not good to silence such warnings so the
best would be to keep them as reminders however unimportant they may
appear.

"No upstream changelog" can remind you to include changelog if/when
upstream decide to add it or it may be a reminder to suggest upstream
to ship it. Also you may choose to generate changelog if you produce
orig.tar from repository checkout. Perhaps there is no reason to
silence this particular warning if upstream changelog is not
shipped...


> > License name "MIT" is incorrect even though upstream may refer to this
> > license as such. "MIT" is considered ambiguous by the Free Software
> > Foundation.
> 
> Yes, I saw that, which is why I included the full license text. I assumed
> that would disambiguate it. Does the "ambiguous" designation mean that the
> name "MIT" should simply not be used? I have changed it to "MIT Old Style".

I think you can use "MIT" to refer to new MIT license text but perhaps
it would be better to call it "Expat" as advised in
copyright-format-specification-1.0: "There are many versions of the
MIT license. Please use Expat instead, when it matches".

Please do not use spaces in short license name -- see examples in
copyright-format-1.0 specification which clearly state that "License
names are case-insensitive, and may not contain spaces". Remember I
suggested to use "MIT-old-style" not "MIT Old Style"? ;)

 
> > Specifically I think it is a good practice to maintain "Forwarded" and
> > "Last-Update" headers.
> 
> All patches now have these.

Thanks. As for usage of "Forwarded" field it is unusual to leave it
empty.  When your patch have only debian customisation and not useful
for upstream just use "Forwarded: not-needed" and you can skip long
explanation (in description) why and how this patch is not useful for
forwarding.


> Again, thank you for your review. I appreciate all the information you've
> shared, and I think the package is much improved after these changes.

Thank you, it's been a pleasure to help. :)

I checked updated version and to my taste the car is still moving too
fast. Of course this is not a problem, just feedback.


All the best,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

I hate all sports as rabidly as a person who likes sports hates common
sense.
        -- H. L. Mencken