[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#705698: RFS: dwb/20130409hg-4



Control: owner -1 !

Hi Nathan,

I'd be happy to upload the package for you after wheezy has been released and
the points below have been fixed.

On 2013-04-18 12:31:27, Nathan Owens wrote:
>     dget -x
> http://mentors.debian.net/debian/pool/main/d/dwb/dwb_20130409hg-4.dsc

That's now
http://mentors.debian.net/debian/pool/main/d/dwb/dwb_20130424hg-1.dsc

 * Current Standards-Version is 3.9.4.

 * Why did you add libjavascriptcoregtk-3.0-0 and libwebkitgtk-3.0-0 to dwb's
   Depends? They are added to ${shlibs:Depends} by dpkg-shlibdeps anyway.

 * If dwb adds itself as alternative to www-browser, please also add a Provides:
   www-browser.

 * Please also add dwb.1 as alternative for x-www-browser.1. You can have a look
   at surf's post{inst,prerm} for an example.

 * The postinstall and postrm script do not fail on errors. Please read the
   third paragraph of Policy 6.1.

 * The postrm script should be a prerm script. The shebang of both scripts can
   be /bin/sh. No need for bash here.

 * Why are you calling update-menus in the postinst and postrm script manually?
   dh_installmenu inserts code to call update-menus.

 * Please add DEP-3 headers to the patches in debian/patches.

 * The copyright years in debian/copyright are not up-to-date. Please correct
   them.

 * In debian/changelog, please add a newline between the changelog trialer and
   the next entry.

 * Since the version is a snapshot from upstream's repo, please add a
   get-orig-source target that creates the orig tarball.

Regards
-- 
Sebastian Ramacher

Attachment: signature.asc
Description: Digital signature


Reply to: