Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml

[Paul Wise <pabs@debian.org>]

I don't intend to sponsor this package, but here is a review:

You might want to get involved in the ocaml team:

http://wiki.debian.org/Teams/OCamlTaskForce

Please drop the unnessecary information from the patch header,
including the partial changelog and the stuff about patch tagging
guidelines.

Please get the patch included upstream.

Please improve your watch file:

http://wiki.debian.org/debian/watch#Common_mistakes

There should be no need for .PHONY in debian/rules.

The lintian override should probably be replaced by a bug against
lintian or blhc.

The copyright/license info for rss_date.mli/rss_date.ml is incomplete.

Automatic checks:

http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package

ocamlc:

File "rss_date.ml", line 220, characters 10-280:
Warning 25: bad style, all clauses in this pattern-matching are guarded.

lintian:

P: librss-ocaml: no-upstream-changelog
P: librss-ocaml-dev: no-upstream-changelog

similarity-tester:

rss_types.ml               consists  for  85  %  of  ./rss.ml
           material

-- 
bye,
pabs

http://wiki.debian.org/PaulWise