Bug#702137: RFS: crosslibs/2.5-2 ITP
On Sun, Mar 3, 2013 at 9:31 AM, Brian Bosak wrote:
> More information about hello can be obtained from http://www.example.com.
That is obviously not true.
Here is my review of the package (I don't intend to sponsor it):
You are supposed to file an Intent To Package (ITP) bug before
starting packaging. Luckly no-one else appears to be packaging it yet,
but to ensure there is no duplication of effort, please file one.
http://www.debian.org/devel/wnpp/#l1
Please delete all the .ex files in debian/ since those are examples.
Your debian/rules does not need any of the comments that are in it,
please remove them.
Please add --parallel to the arguments of dh in debian/rules.
Both README.source and README.Debian don't appear to be needed, please
remove them.
The upstream NEWS file is empty, don't distribute it (see debian/docs).
The debian/copyright file claims example.com is the homepage, please fix that.
Your email address in debian/copyright is wrong.
The comments in the debian/copyright file are not needed, please remove them.
There don't appear to be any copyright statements or license grants,
are you sure we are allowed to distribute it? In any case the
copyright/license info in debian/copyright is probably wrong.
Please run wrap-and-sort -sa to wrap and sort various files properly,
especially the description in debian/control, which is incorrectly
wrapped
The Standards-Version is out-of-date, please read the upgrading
checklist and update it:
http://www.debian.org/doc/debian-policy/upgrading-checklist
The URL in CrossLibs.pc.in looks bogus, please remove it.
I don't think it is a good idea to ship code that is known to
segfault, please fix libCrossLibs.cpp or the comment in it.
Please switch from autotools-dev to dh-autoreconf.
Since you appear to be upstream, please read our upstream guide:
http://wiki.debian.org/UpstreamGuide
Automatic checks:
https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
gcc:
libCrossLibs.cpp: In member function 'void
Compiler::ReadAll(wchar_t*&, int, ...)':
libCrossLibs.cpp:1716:24: warning: 'wchar_t' is promoted to 'int' when
passed through '...' [enabled by default]
libCrossLibs.cpp:1716:24: note: (so you should pass 'int' not
'wchar_t' to 'va_arg')
libCrossLibs.cpp:1716:24: note: if this code is reached, the program will abort
libCrossLibs.cpp: In member function 'std::wstring
Compiler::ReadToCharacter(wchar_t*&, int, ...)':
libCrossLibs.cpp:1697:24: warning: 'wchar_t' is promoted to 'int' when
passed through '...' [enabled by default]
libCrossLibs.cpp:1697:24: note: if this code is reached, the program will abort
lintian:
W: crosslibs source: dh-make-template-in-source debian/crosslibs.cron.d.ex
W: crosslibs source: dh-make-template-in-source debian/crosslibs.default.ex
W: crosslibs source: dh-make-template-in-source debian/crosslibs.doc-base.EX
W: crosslibs source: dh-make-template-in-source debian/emacsen-install.ex
W: crosslibs source: dh-make-template-in-source debian/emacsen-remove.ex
W: crosslibs source: dh-make-template-in-source debian/emacsen-startup.ex
W: crosslibs source: dh-make-template-in-source debian/init.d.ex
W: crosslibs source: dh-make-template-in-source debian/manpage.1.ex
W: crosslibs source: dh-make-template-in-source debian/manpage.sgml.ex
W: crosslibs source: dh-make-template-in-source debian/manpage.xml.ex
W: crosslibs source: dh-make-template-in-source debian/menu.ex
W: crosslibs source: dh-make-template-in-source debian/postinst.ex
W: crosslibs source: dh-make-template-in-source debian/postrm.ex
W: crosslibs source: dh-make-template-in-source debian/preinst.ex
W: crosslibs source: dh-make-template-in-source debian/prerm.ex
W: crosslibs source: dh-make-template-in-source debian/watch.ex
W: crosslibs source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
I: crosslibs source: debian-watch-file-is-missing
W: crosslibs: package-name-doesnt-match-sonames libCrossLibs0
W: crosslibs: hardening-no-relro usr/lib/libCrossLibs.so.0.0.0
W: crosslibs: hardening-no-fortify-functions usr/lib/libCrossLibs.so.0.0.0
W: crosslibs: debian-changelog-line-too-long line 5
E: crosslibs: helper-templates-in-copyright
W: crosslibs: copyright-has-url-from-dh_make-boilerplate
E: crosslibs: copyright-contains-dh_make-todo-boilerplate
W: crosslibs: readme-debian-contains-invalid-email-address brian@unknown
W: crosslibs: extended-description-line-too-long
I: crosslibs: extended-description-is-probably-too-short
E: crosslibs: non-empty-dependency_libs-in-la-file usr/lib/libCrossLibs.la
W: crosslibs: non-dev-pkg-with-shlib-symlink
usr/lib/libCrossLibs.so.0.0.0 usr/lib/libCrossLibs.so
I: crosslibs: no-symbols-control-file usr/lib/libCrossLibs.so.0.0.0
todo grep:
./include/libCrossLibs.h://TODO: Remove GUI library (this is not
something which should be standardized in a core library)
./libCrossLibs/libCrossLibs.cpp://TODO: IC80FS segfault is caused by
faulty memory allocator. Fix it.
./libCrossLibs/libCrossLibs.cpp: //TODO: Defragment the heap
./libCrossLibs/libCrossLibs.cpp: //TODO: Insert jump statements after
data section
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: