Bug#701766: RFS: python-libpcap/0.6.2-1 [QA]
* Prach Pongpanich <prachpub@gmail.com>, 2013-02-28, 01:15:
* Convert debian/rules to debhelper-7 style
Okay, let's have a look at it. :)
override_dh_auto_build:
for i in $(PYVERS);do \
python$$i setup.py build;\
done;
Is it better than what would dh_auto_build do by default? I don't think
it is. See also Policy §4.6.
override_dh_clean:
dh_testdir
dh_testroot
dh_test* don't belong in override_dh_clean.
rm -rf build/
find . -name "*.pyc" | xargs rm -f
for i in $(PYVERS); do \
python$$i setup.py clean;\
done;
All of this is already done by dh_auto_clean.
rm -f build-stamp configure-stamp
I don't think anything actually creates these files. But anyway,
dh_clean removes all *-stamp files if compat is >= 7.
rm -rf $(CURDIR)/debian/python-pylibpcap
This shouldn't be needed; dh_clean removes this directory.
override_dh_auto_install:
for i in $(PYVERS); do\
python$$i setup.py install --no-compile --root=$(CURDIR)/debian/python-libpcap --install-layout=deb; \
done;
Again, I don't think it's better than what dh_auto_install does.
dh_strip
dh_strip doesn't belong in override_dh_auto_install.
override_dh_install:
dh_installchangelogs ChangeLog
Did you mean "override_dh_installchangelogs:" here?
--
Jakub Wilk
Reply to: