Bug#701543: RFS: spout/1.4-1 [ITA] -- Tiny abstract black and white 2D cave-shooter

[Scott Leggett <scott@sl.id.au>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 25/02/13 01:17, Anton Gladky wrote:
> Hi Scott,
> 
> thanks for adopting the package. There are a  couple of
> notes/questions:

Hi Anton, thanks for the review. As you can see, I'm quite new at this!

> 
> 1. Why do you use compat level 8, not 9? 2. The current
> Standards-Version is now 3.9.4.

I used compat level 8 and Standards-Version 3.9.3 because these are
the versions which dh_make automatically inserts when debianising an
application. Thanks for the heads-up regarding the new versions - I've
fixed the packaging.

For future reference, where/when do these new versions get announced
and/or become official?

> 3. Why VCS-field is commented out? It is better to use VCS for
> packaging.

Yes, you are right. I have pushed the packaging to github and updated
the VCS fields.

> 4. Why libsdl1.2debian is injected to Depends manually? Is it
> linked against spout?

No. This was a mistake due to my misunderstanding of the misc:shlibs
variable. The manual depends has been removed.

> 5. I would suggest to target the upload into experimental branch
> instead of unstable due to a freeze-period.

Thanks for the tip, I've changed the upload to target experimental.

> 6. It seems, desktop-file is not installing.

You are right, and it also had some other issues which I've now fixed
to lintian's satisfaction.

Thanks again for the thorough review!

I've attached the updated changelog below:

- ---

spout (1.4-1) experimental; urgency=low

  * New Debian maintainer. (Closes: #691830)
  * Imported new upstream version 1.4.
  * New upstream maintainer and homepage.
  * Fix typo and other formatting issues in .desktop file. (Closes:
#556938)
  * Apply 64-bit segfault patch to upstream.
  * Merge new upstream and old Debian man pages.
  * Build-depend on hardening-wrapper.
  * Patched hardening errors.
  * Updated packaging to use debhelper, quilt 3.0.
  * Bump standards version to 3.9.4.
  * Bump compat version to 9.
  * Add new packaging VCS information.

 -- Scott Leggett <scott@sl.id.au>  Mon, 25 Feb 2013 23:23:58 +1100
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJRK12FAAoJEHlzKPr+55fVw/kQAJH+rxguDh/4IX9Z1VltdCb8
Xo3Cvby4H1y+fPRFZt2ppasuSRaTaxMQ3lnu/raDMuOEb8WuwRUlQpGZzbw5OMg1
oXATlptzde9asSdj2LpwlRw83pYAICCuBk3vqneWfT91timM45bDTjBG1c/ZO+6i
FVtQpP9bY7FU2YCDa42cGIziWuVfNNtVnTy3NPX4YJy2//Ru1JqHdTozhAx08s15
Cy8X+pVElrAQJsS00xOamLr0Ug8iSW8t1mZHoMEY2RrRzad9qCsxYTwNohvHe0nq
TPOqDgiB4XbkL0kH1aqGZBCkE8/+OqZzsFtlEzOn5d3InHcIpFxuDtfpxlMkV8h9
/zcXxRQzoXM6Amr5yhnEc6Kv1PEmrxigvpWYBCg6IJkjAcEq3s9MjjMtY1sF+ykv
K78Po3CcoeCqInZ+CBjcUI2fMRL6bGAVFnj7EAXauXWkMO7rWeM0U5sr9eoEc4hD
rFBZMzyCGbjq6zTAU2oc7WVoM7fEhJkQBk5SLVYpjLpSl1lx1UMXSReJgmZ/eRnk
z6O4vP6FxY7U27I7DHQefhSzz5Kquej/lpPuu5SdoMISnh3yUs7M+4r8I70CemFy
YyUdp6195gytSKM371oBDk/IJd3hHJQU2Q2FIyFyOaIHf6y5eU1re7BVB3p4JzOr
GkyybyShDghJQ+RiaHzf
=F10K
-----END PGP SIGNATURE-----