Control: owner -1 !
Hi Josué,
I had a look at your mp3diags package and found the following issue. Once the
issues are fixed I'm happy to upload the package for you.
On 2012-12-29 21:44:47, Josué Ortega wrote:
> dget -x http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.0.12.079-1.dsc
* Please prepare an upload to experimental so that we can keep unstable clean
until the release of wheezy.
* -g is not passed to the compiler and thus DEB_BUILD_OPTIONS=nostrip is not
supported. Please check Debian Policy §4.9.1 and §10.1.
* The package is built without hardening flags. In particular lintian emits:
W: mp3diags: hardening-no-relro usr/bin/mp3diags
W: mp3diags: hardening-no-fortify-functions usr/bin/mp3diags
Please build the package with hardening flags enabled and check the build log
with blhc.
The last two issues can be solved by using dpkg-buildflags directly or by
including /usr/share/dpkg/buildflags.mk in debian/rules. dh_auto_* also set
them in compat level 9.
* The package fails to build twice in a row. Please have a look at the
attached file for the log of the second build. The files dpkg-source is
complaining about come from running cmake by dh_auto_configure. However,
elsewhere qmake is used to build mp3diags. Please decide on one of these
two build systems.
If you choose qmake, note that debhelper supports qmake since 7.4.12. So
removing the overrides for dh_auto_clean, dh_auto_build and passing -Sqmake
to dh should be enough.
* lintian also emits:
W: mp3diags source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
I: mp3diags: spelling-error-in-binary usr/bin/mp3diags teH the
Please fix these issues and ping me when you're done.
One other thing: Vcs-* lists a collab-maint repo which has not been updated
since the last upload by Alessio. It'd be great if you could push your work
there. If you just don't have access to this repository, please say so.
Cheers
--
Sebastian Ramacher
dpkg-buildpackage: source package mp3diags dpkg-buildpackage: source version 1.0.12.079-1 dpkg-buildpackage: source changed by Josue Ortega <josueortega@debian.org.gt> dpkg-buildpackage: host architecture amd64 dpkg-source --before-build mp3diags-1.0.12.079 fakeroot debian/rules clean dh clean --parallel dh_testdir -O--parallel debian/rules override_dh_auto_clean make[1]: Entering directory `/tmp/mp3diags-1.0.12.079' [ ! -f Makefile ] || /usr/bin/make clean make[2]: Entering directory `/tmp/mp3diags-1.0.12.079' cd src/ && /usr/bin/make -f Makefile clean make[3]: Entering directory `/tmp/mp3diags-1.0.12.079/src' /usr/bin/make -f Makefile.Release clean make[4]: Entering directory `/tmp/mp3diags-1.0.12.079/src' rm -f release/moc_AboutDlgImpl.cpp release/moc_AlbumInfoDownloaderDlgImpl.cpp release/moc_CommonData.cpp release/moc_ConfigDlgImpl.cpp release/moc_DebugDlgImpl.cpp release/moc_DirFilterDlgImpl.cpp release/moc_DiscogsDownloader.cpp release/moc_DoubleList.cpp release/moc_FileRenamerDlgImpl.cpp release/moc_FilesModel.cpp release/moc_ImageInfoPanelWdgImpl.cpp release/moc_LogModel.cpp release/moc_MainFormDlgImpl.cpp release/moc_MultiLineTvDelegate.cpp release/moc_MusicBrainzDownloader.cpp release/moc_NormalizeDlgImpl.cpp release/moc_NoteFilterDlgImpl.cpp release/moc_NotesModel.cpp release/moc_PaletteDlgImpl.cpp release/moc_RenamerPatternsDlgImpl.cpp release/moc_ScanDlgImpl.cpp release/moc_SessionEditorDlgImpl.cpp release/moc_SessionsDlgImpl.cpp release/moc_StreamsModel.cpp release/moc_TagEditorDlgImpl.cpp release/moc_TagEdtPatternsDlgImpl.cpp release/moc_TagReadPanel.cpp release/moc_TagWriter.cpp release/moc_ThreadRunnerDlgImpl.cpp release/moc_UniqueNotesModel.cpp release/moc_Widgets.cpp release/moc_ExportDlgImpl.cpp release/moc_FullSizeImgDlg.cpp rm -f release/qrc_Mp3Diags.cpp rm -f ui_About.h ui_AlbumInfoDownloader.h ui_Config.h ui_Debug.h ui_DirFilter.h ui_DoubleListWdg.h ui_FileRenamer.h ui_ImageInfoPanel.h ui_MainForm.h ui_Normalize.h ui_NoteFilter.h ui_Palette.h ui_Patterns.h ui_Scan.h ui_SessionEditor.h ui_Sessions.h ui_TagEditor.h ui_ThreadRunner.h ui_Export.h rm -f release/Helpers.o release/main.o release/DiscogsDownloader.o release/DoubleList.o release/FileEnum.o release/FileRenamerDlgImpl.o release/FilesModel.o release/Id3Transf.o release/Id3V230Stream.o release/Id3V240Stream.o release/Id3V2Stream.o release/ImageInfoPanelWdgImpl.o release/LogModel.o release/LyricsStream.o release/MainFormDlgImpl.o release/Mp3Manip.o release/Mp3TransformThread.o release/MpegFrame.o release/MpegStream.o release/MultiLineTvDelegate.o release/MusicBrainzDownloader.o release/NormalizeDlgImpl.o release/NoteFilterDlgImpl.o release/Notes.o release/NotesModel.o release/OsFile.o release/PaletteDlgImpl.o release/RenamerPatternsDlgImpl.o release/ScanDlgImpl.o release/SessionEditorDlgImpl.o release/SessionsDlgImpl.o release/SongInfoParser.o release/StoredSettings.o release/StreamsModel.o release/StructuralTransformation.o release/TagEditorDlgImpl.o release/TagEdtPatternsDlgImpl.o release/TagReadPanel.o release/TagWriter.o release/ThreadRunnerDlgImpl.o release/Transformation.o release/UniqueNotesModel.o release/Widgets.o release/AboutDlgImpl.o release/AlbumInfoDownloaderDlgImpl.o release/ApeStream.o release/CheckedDir.o release/ColumnResizer.o release/CommonData.o release/CommonTypes.o release/ConfigDlgImpl.o release/DataStream.o release/DebugDlgImpl.o release/DirFilterDlgImpl.o release/Version.o release/fstream_unicode.o release/ExportDlgImpl.o release/SerSupport.o release/FullSizeImgDlg.o release/moc_AboutDlgImpl.o release/moc_AlbumInfoDownloaderDlgImpl.o release/moc_CommonData.o release/moc_ConfigDlgImpl.o release/moc_DebugDlgImpl.o release/moc_DirFilterDlgImpl.o release/moc_DiscogsDownloader.o release/moc_DoubleList.o release/moc_FileRenamerDlgImpl.o release/moc_FilesModel.o release/moc_ImageInfoPanelWdgImpl.o release/moc_LogModel.o release/moc_MainFormDlgImpl.o release/moc_MultiLineTvDelegate.o release/moc_MusicBrainzDownloader.o release/moc_NormalizeDlgImpl.o release/moc_NoteFilterDlgImpl.o release/moc_NotesModel.o release/moc_PaletteDlgImpl.o release/moc_RenamerPatternsDlgImpl.o release/moc_ScanDlgImpl.o release/moc_SessionEditorDlgImpl.o release/moc_SessionsDlgImpl.o release/moc_StreamsModel.o release/moc_TagEditorDlgImpl.o release/moc_TagEdtPatternsDlgImpl.o release/moc_TagReadPanel.o release/moc_TagWriter.o release/moc_ThreadRunnerDlgImpl.o release/moc_UniqueNotesModel.o release/moc_Widgets.o release/moc_ExportDlgImpl.o release/moc_FullSizeImgDlg.o release/qrc_Mp3Diags.o rm -f *~ core *.core make[4]: Leaving directory `/tmp/mp3diags-1.0.12.079/src' /usr/bin/make -f Makefile.Debug clean make[4]: Entering directory `/tmp/mp3diags-1.0.12.079/src' rm -f debug/moc_AboutDlgImpl.cpp debug/moc_AlbumInfoDownloaderDlgImpl.cpp debug/moc_CommonData.cpp debug/moc_ConfigDlgImpl.cpp debug/moc_DebugDlgImpl.cpp debug/moc_DirFilterDlgImpl.cpp debug/moc_DiscogsDownloader.cpp debug/moc_DoubleList.cpp debug/moc_FileRenamerDlgImpl.cpp debug/moc_FilesModel.cpp debug/moc_ImageInfoPanelWdgImpl.cpp debug/moc_LogModel.cpp debug/moc_MainFormDlgImpl.cpp debug/moc_MultiLineTvDelegate.cpp debug/moc_MusicBrainzDownloader.cpp debug/moc_NormalizeDlgImpl.cpp debug/moc_NoteFilterDlgImpl.cpp debug/moc_NotesModel.cpp debug/moc_PaletteDlgImpl.cpp debug/moc_RenamerPatternsDlgImpl.cpp debug/moc_ScanDlgImpl.cpp debug/moc_SessionEditorDlgImpl.cpp debug/moc_SessionsDlgImpl.cpp debug/moc_StreamsModel.cpp debug/moc_TagEditorDlgImpl.cpp debug/moc_TagEdtPatternsDlgImpl.cpp debug/moc_TagReadPanel.cpp debug/moc_TagWriter.cpp debug/moc_ThreadRunnerDlgImpl.cpp debug/moc_UniqueNotesModel.cpp debug/moc_Widgets.cpp debug/moc_ExportDlgImpl.cpp debug/moc_FullSizeImgDlg.cpp rm -f debug/qrc_Mp3Diags.cpp rm -f ui_About.h ui_AlbumInfoDownloader.h ui_Config.h ui_Debug.h ui_DirFilter.h ui_DoubleListWdg.h ui_FileRenamer.h ui_ImageInfoPanel.h ui_MainForm.h ui_Normalize.h ui_NoteFilter.h ui_Palette.h ui_Patterns.h ui_Scan.h ui_SessionEditor.h ui_Sessions.h ui_TagEditor.h ui_ThreadRunner.h ui_Export.h rm -f debug/Helpers.o debug/main.o debug/DiscogsDownloader.o debug/DoubleList.o debug/FileEnum.o debug/FileRenamerDlgImpl.o debug/FilesModel.o debug/Id3Transf.o debug/Id3V230Stream.o debug/Id3V240Stream.o debug/Id3V2Stream.o debug/ImageInfoPanelWdgImpl.o debug/LogModel.o debug/LyricsStream.o debug/MainFormDlgImpl.o debug/Mp3Manip.o debug/Mp3TransformThread.o debug/MpegFrame.o debug/MpegStream.o debug/MultiLineTvDelegate.o debug/MusicBrainzDownloader.o debug/NormalizeDlgImpl.o debug/NoteFilterDlgImpl.o debug/Notes.o debug/NotesModel.o debug/OsFile.o debug/PaletteDlgImpl.o debug/RenamerPatternsDlgImpl.o debug/ScanDlgImpl.o debug/SessionEditorDlgImpl.o debug/SessionsDlgImpl.o debug/SongInfoParser.o debug/StoredSettings.o debug/StreamsModel.o debug/StructuralTransformation.o debug/TagEditorDlgImpl.o debug/TagEdtPatternsDlgImpl.o debug/TagReadPanel.o debug/TagWriter.o debug/ThreadRunnerDlgImpl.o debug/Transformation.o debug/UniqueNotesModel.o debug/Widgets.o debug/AboutDlgImpl.o debug/AlbumInfoDownloaderDlgImpl.o debug/ApeStream.o debug/CheckedDir.o debug/ColumnResizer.o debug/CommonData.o debug/CommonTypes.o debug/ConfigDlgImpl.o debug/DataStream.o debug/DebugDlgImpl.o debug/DirFilterDlgImpl.o debug/Version.o debug/fstream_unicode.o debug/ExportDlgImpl.o debug/SerSupport.o debug/FullSizeImgDlg.o debug/moc_AboutDlgImpl.o debug/moc_AlbumInfoDownloaderDlgImpl.o debug/moc_CommonData.o debug/moc_ConfigDlgImpl.o debug/moc_DebugDlgImpl.o debug/moc_DirFilterDlgImpl.o debug/moc_DiscogsDownloader.o debug/moc_DoubleList.o debug/moc_FileRenamerDlgImpl.o debug/moc_FilesModel.o debug/moc_ImageInfoPanelWdgImpl.o debug/moc_LogModel.o debug/moc_MainFormDlgImpl.o debug/moc_MultiLineTvDelegate.o debug/moc_MusicBrainzDownloader.o debug/moc_NormalizeDlgImpl.o debug/moc_NoteFilterDlgImpl.o debug/moc_NotesModel.o debug/moc_PaletteDlgImpl.o debug/moc_RenamerPatternsDlgImpl.o debug/moc_ScanDlgImpl.o debug/moc_SessionEditorDlgImpl.o debug/moc_SessionsDlgImpl.o debug/moc_StreamsModel.o debug/moc_TagEditorDlgImpl.o debug/moc_TagEdtPatternsDlgImpl.o debug/moc_TagReadPanel.o debug/moc_TagWriter.o debug/moc_ThreadRunnerDlgImpl.o debug/moc_UniqueNotesModel.o debug/moc_Widgets.o debug/moc_ExportDlgImpl.o debug/moc_FullSizeImgDlg.o debug/qrc_Mp3Diags.o rm -f *~ core *.core make[4]: Leaving directory `/tmp/mp3diags-1.0.12.079/src' make[3]: Leaving directory `/tmp/mp3diags-1.0.12.079/src' make[2]: Leaving directory `/tmp/mp3diags-1.0.12.079' dh_clean bin/MP3Diags Makefile src/Makefile src/Makefile.Debug \ src/Makefile.Release rm -rf src/release make[1]: Leaving directory `/tmp/mp3diags-1.0.12.079' dh_clean -O--parallel dpkg-source -b mp3diags-1.0.12.079 dpkg-source: info: using source format `3.0 (quilt)' dpkg-source: info: building mp3diags using existing ./mp3diags_1.0.12.079.orig.tar.gz dpkg-source: error: cannot represent change to obj-x86_64-linux-gnu/CMakeFiles/CMakeDetermineCompilerABI_CXX.bin: binary file contents changed dpkg-source: error: add obj-x86_64-linux-gnu/CMakeFiles/CMakeDetermineCompilerABI_CXX.bin in debian/source/include-binaries if you want to store the modified binary in the debian tarball dpkg-source: error: cannot represent change to obj-x86_64-linux-gnu/CMakeFiles/CMakeDetermineCompilerABI_C.bin: binary file contents changed dpkg-source: error: add obj-x86_64-linux-gnu/CMakeFiles/CMakeDetermineCompilerABI_C.bin in debian/source/include-binaries if you want to store the modified binary in the debian tarball dpkg-source: error: cannot represent change to obj-x86_64-linux-gnu/CMakeFiles/CompilerIdC/a.out: binary file contents changed dpkg-source: error: add obj-x86_64-linux-gnu/CMakeFiles/CompilerIdC/a.out in debian/source/include-binaries if you want to store the modified binary in the debian tarball dpkg-source: error: cannot represent change to obj-x86_64-linux-gnu/CMakeFiles/CompilerIdCXX/a.out: binary file contents changed dpkg-source: error: add obj-x86_64-linux-gnu/CMakeFiles/CompilerIdCXX/a.out in debian/source/include-binaries if you want to store the modified binary in the debian tarball dpkg-source: error: unrepresentable changes to source dpkg-buildpackage: error: dpkg-source -b mp3diags-1.0.12.079 gave error exit status 2
Attachment:
signature.asc
Description: Digital signature