Bug#696782: RFS: sequitur-g2p/0.0.r1668-1 [ITP] -- Grapheme to Phoneme conversion tool
Il 05/02/2013 18:28, Jakub Wilk ha scritto:
> * Giulio Paci <giuliopaci@gmail.com>, 2013-02-04, 22:51:
>>>>> lintian4python emits a bunch of tags:
>>>>>
>>>>> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/bin/sequitur-g2p:46
>>>>> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/Evaluation.py:34
> [...]
>>>
>>> The patch that fixes this is huge, and clearly not maintainable. Please make sure this problem is fixed upstream by their next release.
>>>
>>> Please also ask them to not include *.pyc files in the tarballs.
>>
>> I will do, if I will ever be able to get in contact with someone upstream.
>> Unfortunately the original author is not working anymore for RTWH Aachen University.
>> I wrote two times to the head of the department responsible for this software to ask about the license and to ask if there is anyone that I can contact to provide
>> patches, but I received no answer yet.
>
> If it turns out the upstream is dead, I'd suggest dropping the indentation_fixes patch and living with the ugliness of tabs+spaces indentation.
I still hope to get an answer... So let's wait a few more days before dropping the indentation_fixes.patch.
> You don't need to build-depend on both python-all-dev and python-all. The former is enough.
Dropped python-all dependency.
> Are the Python modules shipped by this package supposed to be used by other software?
> If not, they should be moved to a private directory.
> If yes, then they need to be renamed or moved into a namespace, because their are way to generic ("tool", "misc", etc.).
It is the former case. It was my fault because I did not read carefully the Debian policy about Python.
I moved the modules to /usr/lib/sequitur-g2p/python/<version>/dist-packages. After installation I also change the main script so that it can locate the modules.
Is this approach ok? I was not able to understand it from the Debian policy.
Bests,
Giulio.
Reply to: