[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#698853: RFS: gosa/2.7.4-4.1 [RC] [NMU] -- make package installable again



Hi,

On 24.01.2013 16:09, Dominik George wrote:
> Package: sponsorship-requests
> Severity: important
> Control: tags 698635 + patch pending
> 
> Dear mentors,
> 
> I am looking for a sponsor for my NMU of package "gosa". The upload
> would fix RC bug #698635.
> 

> -  a2enmod headers
> +  [[ -x /usr/sbin/a2enmod ]] && a2enmod headers



Unfortunately the fix is not good enough. Two issues:
a/ the script uses set -e, this means it will it exit with an error if
a2enmod is missing
b/ [[ (double brackets) is non-posix and not supported by all shells, so
you should avoid that in favour of [ ]. checkbashims can help detect
such errors.

Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: