Bug#696782: RFS: sequitur-g2p/0.0.r1668-1 [ITP] -- Grapheme to Phoneme conversion tool
Il 28/12/2012 18:31, Jakub Wilk ha scritto:
> * Giulio Paci <giuliopaci@gmail.com>, 2012-12-27, 03:52:
>> http://mentors.debian.net/debian/pool/main/s/sequitur-g2p/sequitur-g2p_0.0.r1668-1.dsc
>
> The license has this additional clause:
>
> Should a provision of no. 9 and 10 of the GNU General Public License be invalid or become invalid, a valid provision is deemed to have been agreed upon which comes closest
> to what the parties intended commercially. In any case guarantee/warranty shall be limited to gross negligent actions or intended actions or fraudulent concealment.
>
> Shouldn't that be "11 and 12" instead of "9 and 10"? I can't make sense of it otherwise...
I asked the author. He explained that the problem was their legal department was worried that the license terms could be changed by third party (i.e., FSF).
Our thought is that this clause is there just to say that the software is released under GPL-2, so the reference to 9 and 10 should be right.
Unfortunately the author is not working anymore for the copyright owner, and he cannot change the license. I wrote to the current head of department last week, but I have
not received any answer yet.
Do you think the license, as it is, is acceptable?
> Also, this clause should be included in debian/copyright.
>
> The package FTBFS here:
> | running build_ext
> | building '_sequitur_' extension
> | swigging sequitur.i to sequitur_wrap.cpp
> | swig -python -c++ -shadow -o sequitur_wrap.cpp sequitur.i
> | unable to execute swig: No such file or directory
> | error: command 'swig' failed with exit status 1
Added swig dependency.
> Typo in SequiturTool.py: occurence -> ocurrence. Also, "overlapping occurrence counts" sounds a bit awkward to me. (But maybe it's just me, I'm not a native speaker.)
For me it was very hard to understand the purpose of the option. So I read again the main paper describing sequitur g2p and then asked the author for confirmation.
I tried to restate the option description in a more clear form.
> lintian4python emits a bunch of tags:
>
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/bin/sequitur-g2p:46
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/Evaluation.py:34
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/Minimization.py:48
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/SequenceModel.py:37
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/SequiturTool.py:41
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/g2p.py:46
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/misc.py:35
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/sequitur.py:38
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/symbols.py:41
> w: sequitur-g2p: inconsistent-use-of-tabs-and-spaces-in-indentation usr/share/pyshared/tool.py:50
> e: sequitur-g2p: pyflakes-undefined-name usr/bin/sequitur-g2p:132: transposeSample
> e: sequitur-g2p: pyflakes-undefined-name usr/share/pyshared/g2p.py:132: transposeSample
> e: sequitur-g2p: string-exception usr/share/pyshared/Minimization.py:187
> e: sequitur-g2p: string-exception usr/share/pyshared/Minimization.py:230
> i: sequitur-g2p: versioned-python-shebang usr/bin/sequitur-g2p /usr/bin/python2.7
Fixed.
Bests,
Giulio.
Reply to: