Re: [PATCH] nbd: fix build failure after openunix/opennet refactor

[Wouter Verhelst <w@uter.be>]

Hi there,

Sorry for the late reply; applied.

On Mon, Sep 15, 2025 at 12:29:42AM +0000, Yunseong Kim wrote:
> Commit 17043b068f43 ("Refactor the negotiate() and connected functions")
> removed all parameters from openunix() and opennet(), but main()
> still called them with host/port arguments. This causes build errors:
> 
> nbd-client.c:1224:32: error: too many arguments to function ‘openunix’; expected 0, have 1
> nbd-client.c:1226:32: error: too many arguments to function ‘opennet’; expected 0, have 2
> 
> Update the calls in main() to match the new prototypes.
> 
> Fixes: 17043b068f43 ("Refactor the negotiate() and connected functions")
> Signed-off-by: Yunseong Kim <ysk@kzalloc.com>
> ---
>  nbd-client.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/nbd-client.c b/nbd-client.c
> index 158ec80..e809d9c 100644
> --- a/nbd-client.c
> +++ b/nbd-client.c
> @@ -1221,9 +1221,9 @@ int main(int argc, char *argv[]) {
>  
>  	for (i = 0; i < cur_client->nconn; i++) {
>  		if (cur_client->b_unix)
> -			sock = openunix(cur_client->hostn);
> +			sock = openunix();
>  		else
> -			sock = opennet(cur_client->hostn, cur_client->port);
> +			sock = opennet();
>  		if (sock < 0)
>  			exit(EXIT_FAILURE);
>  
> -- 
> 2.51.0
> 
> 

-- 
     w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}

I will have a Tin-Actinium-Potassium mixture, thanks.