Re: [PATCH 03/10] block: add a store_limit operations for sysfs entries
- To: Damien Le Moal <dlemoal@kernel.org>
- Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>, Nilay Shroff <nilay@linux.ibm.com>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
- Subject: Re: [PATCH 03/10] block: add a store_limit operations for sysfs entries
- From: Christoph Hellwig <hch@lst.de>
- Date: Mon, 6 Jan 2025 11:57:32 +0100
- Message-id: <[🔎] 20250106105732.GA21833@lst.de>
- In-reply-to: <[🔎] a461bbbc-f251-4f44-89c7-f80f72e6e96d@kernel.org>
- References: <[🔎] 20250106100645.850445-1-hch@lst.de> <[🔎] 20250106100645.850445-4-hch@lst.de> <[🔎] a461bbbc-f251-4f44-89c7-f80f72e6e96d@kernel.org>
On Mon, Jan 06, 2025 at 07:46:19PM +0900, Damien Le Moal wrote:
> The freeze must NOT be done for the "if (entry->store_limit)" case. So this
> needs to go int the "else". Otherwise, you still have freeze the take limit
> lock order which can cause the ABBA deadlocks in SCSI sd.
That is fixed in the next patch. This one is pure refactoring without
behavior change.
Reply to: