Hi Eric,
Sorry for the late reply; I was travelling a lot in the last two or so
months and had little time to look at things in my time off.
This looks good to me; please commit.
On Thu, Dec 12, 2024 at 12:36:22PM -0600, Eric Blake wrote:
> ping
>
> This patch series is being added as a dependency to KubeSAN:
> https://gitlab.com/kubesan/kubesan/-/merge_requests/100/diffs?commit_id=89a370dcde
> https://quay.io/repository/kubesan/nbd-client-i
>
> so it would be nice to have it upstream instead of in a one-off fork.
>
> On Tue, Nov 19, 2024 at 05:27:27PM -0600, Eric Blake wrote:
> > Stefan Hajnoczi pointed out to me that since kernel 5.14 (commit
> > 6497ef8d in Apr 2021), the netlink interface has allowed userspace to
> > pass in an arbitrary backend string visible at
> > /sys/block/nbdN/backend, and which prevents the abuse of netlink to
> > arbitrarily reconfigure an active NBD connection to a different
> > backend, for some added safety when multiple threads might be racing
> > to create NBD devices. Time to expose it in nbd-client, along with
> > first fixing some regressions along the way.
> >
> > Eric Blake (2):
> > nbd-client: Fix use without -N
> > nbd-client: Add support for setting /sys/block/nbdN/backend
> >
> > .gitignore | 1 +
> > man/nbd-client.8.sgml.in | 24 +++++++++++++++++++++++-
> > nbd-client.c | 30 ++++++++++++++++++++++++------
> > nbd-netlink.h | 7 +++++--
> > 4 files changed, 53 insertions(+), 9 deletions(-)
> >
> > --
> > 2.47.0
> >
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.
> Virtualization: qemu.org | libguestfs.org
>
>
--
w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}
I will have a Tin-Actinium-Potassium mixture, thanks.