Re: [PATCH 12/12] block: add special APIs for run-time disabling of discard and friends
- To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, "Martin K. Petersen" <martin.petersen@oracle.com>
- Cc: Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, Ilya Dryomov <idryomov@gmail.com>, Dongsheng Yang <dongsheng.yang@easystack.cn>, Roger Pau Monné <roger.pau@citrix.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org
- Subject: Re: [PATCH 12/12] block: add special APIs for run-time disabling of discard and friends
- From: Damien Le Moal <dlemoal@kernel.org>
- Date: Wed, 29 May 2024 17:30:45 +0900
- Message-id: <[🔎] cf5628a4-50e5-4397-9633-c00a3df2a2df@kernel.org>
- In-reply-to: <[🔎] 20240529050507.1392041-13-hch@lst.de>
- References: <[🔎] 20240529050507.1392041-1-hch@lst.de> <[🔎] 20240529050507.1392041-13-hch@lst.de>
On 5/29/24 14:04, Christoph Hellwig wrote:
> A few drivers optimistically try to support discard, write zeroes and
> secure erase and disable the features from the I/O completion handler
> if the hardware can't support them. This disable can't be done using
> the atomic queue limits API because the I/O completion handlers can't
> take sleeping locks or freezer the queue. Keep the existing clearing
s/freezer/freeze
> of the relevant field to zero, but replace the old blk_queue_max_*
> APIs with new disable APIs that force the value to 0.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
With the typo fixed, looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
Reply to: