Re: Replace u32 and u64 by standard compliant uint32_t, uint64_t

[Wouter Verhelst <w@uter.be>]

On Sun, May 12, 2024 at 12:10:36PM +0200, Lars Rohwedder wrote:
> Hi all,
> 
> I'd like to get rid of the mixture non-standard typedefs u32, u64 with
> standard-compliant uint32_t, uint64_t.
> 
> Some examples: negotiate() in nbd-client.c, ntohll() in cliserv.c or
> send_export_info() in nbd-server.c.
> 
> 
> AFAIK u32, u64 came originally from Linux kernel source but in the NBD
> source exists an additional declaration in cliserv.h which might be also
> misleading on some architectures, so I'd like to change the whole code
> base to use standard types.
> 
> What do you think?

Sure.

Part of the NBD code predates C99, which introduced stdint.h. I've never
seen it as a priority ("it works"), but we might as well.

> I also have a patch & github merge request in petto, but it depends on
> the former "const void*" patch, so I'd wait for its landing first. :-)

That has now happened. Thanks :-)

-- 
     w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}

I will have a Tin-Actinium-Potassium mixture, thanks.