Re: [PATCH 3/9] block: default the discard granularity to sector size
- To: John Pittman <jpittman@redhat.com>
- Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Josef Bacik <josef@toxicpanda.com>, Minchan Kim <minchan@kernel.org>, Sergey Senozhatsky <senozhatsky@chromium.org>, Coly Li <colyli@suse.de>, Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org
- Subject: Re: [PATCH 3/9] block: default the discard granularity to sector size
- From: Christoph Hellwig <hch@lst.de>
- Date: Wed, 3 Jan 2024 08:57:29 +0100
- Message-id: <[🔎] 20240103075729.GA485@lst.de>
- In-reply-to: <[🔎] CA+RJvhwg3YXAzSk81nMGw=_3OMo6P=XcXBUFUAXSBcyXH6gkDg@mail.gmail.com>
- References: <20231228075545.362768-1-hch@lst.de> <20231228075545.362768-4-hch@lst.de> <[🔎] CA+RJvhwg3YXAzSk81nMGw=_3OMo6P=XcXBUFUAXSBcyXH6gkDg@mail.gmail.com>
On Tue, Jan 02, 2024 at 05:11:19PM -0500, John Pittman wrote:
> Hi Christoph, is there a reason you used 512 instead of SECTOR_SIZE
> from include/linux/blk_types.h? Thanks!
To match the logical_block_size/physical_block_size/io_min
assignments just below.
Reply to: