On 2/23/23 18:13, Jakub Kicinski wrote: > Use the macro for checking presence of required attributes. > It has the advantage of reporting to the user which attr > was missing in a machine-readable format (extack). > > Reviewed-by: Josef Bacik <josef@toxicpanda.com> > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck