Re: Performance drop due to alloc_workqueue() misuse and recent change
- To: Naohiro Aota <Naohiro.Aota@wdc.com>
- Cc: Lai Jiangshan <jiangshanlai@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>, "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>, "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>, "coreteam@netfilter.org" <coreteam@netfilter.org>, "dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "gfs2@lists.linux.dev" <gfs2@lists.linux.dev>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-bcachefs@vger.kernel.org" <linux-bcachefs@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "linux-cachefs@redhat.com" <linux-cachefs@redhat.com>, "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>, "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>, "linux-erofs@lists.ozlabs.org" <linux-erofs@lists.ozlabs.org>, "linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>, "linux-fscrypt@vger.kernel.org" <linux-fscrypt@vger.kernel.org>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>, "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>, "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, "linux-trace-kernel@vger.kernel.org" <linux-trace-kernel@vger.kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>, "nbd@other.debian.org" <nbd@other.debian.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "ntb@lists.linux.dev" <ntb@lists.linux.dev>, "open-iscsi@googlegroups.com" <open-iscsi@googlegroups.com>, "oss-drivers@corigine.com" <oss-drivers@corigine.com>, "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>, "samba-technical@lists.samba.org" <samba-technical@lists.samba.org>, "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>, "virtualization@lists.linux.dev" <virtualization@lists.linux.dev>, "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
- Subject: Re: Performance drop due to alloc_workqueue() misuse and recent change
- From: Tejun Heo <tj@kernel.org>
- Date: Tue, 19 Dec 2023 21:14:59 -1000
- Message-id: <[🔎] ZYKUc7MUGvre2lGQ@slm.duckdns.org>
- In-reply-to: <[🔎] dbu6wiwu3sdhmhikb2w6lns7b27gbobfavhjj57kwi2quafgwl@htjcc5oikcr3>
- References: <[🔎] dbu6wiwu3sdhmhikb2w6lns7b27gbobfavhjj57kwi2quafgwl@htjcc5oikcr3>
Hello, again.
On Mon, Dec 04, 2023 at 04:03:47PM +0000, Naohiro Aota wrote:
...
> In summary, we misuse max_active, considering it is a global limit. And,
> the recent commit introduced a huge performance drop in some cases. We
> need to review alloc_workqueue() usage to check if its max_active setting
> is proper or not.
Can you please test the following branch?
https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git unbound-system-wide-max_active
Thanks.
--
tejun
Reply to: