[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH v3 6/6] RFC: spec: Introduce NBD_REPLY_TYPE_OFFSET_HOLE_EXT

On Thu, Apr 13, 2023 at 05:02:41PM -0500, Eric Blake wrote:
> Rather than requiring all servers and clients to have a 32-bit limit
> on maximum NBD_CMD_READ/WRITE sizes, we can choose to standardize
> support for a 64-bit single I/O transaction now.
> NBD_REPLY_TYPE_OFFSET_DATA can already handle a large reply, but
> NBD_REPLY_TYPE_OFFSET_HOLE needs a 64-bit counterpart.
> By standardizing this, all clients must be prepared to support both
> types of hole type replies, even though most server implementations of
> extended replies are likely to only send one hole type.

I think it's probably a better idea to push this patch to a separate
"extension-*" branch, and link to that from proto.md on master. Those
are documented as "we standardized this, but no first implementor exists

If someone actually comes up with a reason for 64-bit transactions, we
can then see if the spec matches the need and merge it to master.

Otherwise this feels too much like a solution in search of a problem to

With that said, for the things I didn't reply to, you can add:

Reviewed-By: Wouter Verhelst <w@uter.be>


I will have a Tin-Actinium-Potassium mixture, thanks.

Reply to: