[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 3/4] Implement structured reply handling

On Sat, Mar 11, 2023 at 03:07:04PM +0200, w@uter.be wrote:
> From: Wouter Verhelst <w@uter.be>
> This implements the transmission phase part of structured replies as documented
> in doc/proto.txt, but does not do the negotiation phase part of this (yet).
> Signed-off-by: Wouter Verhelst <w@uter.be>

> +static void log_structured_reply(CLIENT *client, struct nbd_structured_reply *prply) {
> +	if (client->transactionlogfd != -1) {
> +		lock_logsem(client);
> +		writeit(client->transactionlogfd, prply, sizeof(*ptply));

nbd-server.c: In function ‘log_structured_reply’:
nbd-server.c:1291:66: error: ‘ptply’ undeclared (first use in this function); did you mean ‘prply’?
 1291 |               writeit(client->transactionlogfd, prply, sizeof(*ptply));
      |                                                                ^~~~~
      |                                                                prply
nbd-server.c:1291:66: note: each undeclared identifier is reported only once for each function it appears in

My R-b assumes the obvious typo fix ;)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply to: