Re: [PATCH 0/5] blk-mq: Add a flag for reserved requests series
- To: John Garry <john.garry@huawei.com>
- Cc: <axboe@kernel.dk>, <damien.lemoal@opensource.wdc.com>, <bvanassche@acm.org>, <hch@lst.de>, <jejb@linux.ibm.com>, <martin.petersen@oracle.com>, <hare@suse.de>, <satishkh@cisco.com>, <sebaddel@cisco.com>, <kartilak@cisco.com>, <linux-rdma@vger.kernel.org>, <linux-mmc@vger.kernel.org>, <linux-nvme@lists.infradead.org>, <linux-s390@vger.kernel.org>, <linux-scsi@vger.kernel.org>, <mpi3mr-linuxdrv.pdl@broadcom.com>, <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <nbd@other.debian.org>
- Subject: Re: [PATCH 0/5] blk-mq: Add a flag for reserved requests series
- From: "Martin K. Petersen" <martin.petersen@oracle.com>
- Date: Tue, 21 Jun 2022 20:51:14 -0400
- Message-id: <[🔎] yq1a6a5ldwv.fsf@ca-mkp.ca.oracle.com>
- In-reply-to: <[🔎] 1655463320-241202-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Fri, 17 Jun 2022 18:55:15 +0800")
- References: <[🔎] 1655463320-241202-1-git-send-email-john.garry@huawei.com>
John,
> In [0] I included "blk-mq: Add a flag for reserved requests" to
> identify if a request is 'reserved' for special handling. Doing this
> is easier than passing a 'reserved' arg to the blk_mq_ops
> callbacks. Indeed, only 1x timeout implementation or blk-mq iter
> function actually uses the 'reserved' arg (or 3x if you count SCSI
> core and FNIC SCSI driver). So this series drops the 'reserved' arg
> for these timeout and iter functions. Christoph suggested that I try
> to upstream now.
Looks OK to me. I agree with the scsi_timeout() suggestion.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
Reply to: