Re: [PATCH 1/5] scsi: core: Remove reserved request time-out handling
- To: John Garry <john.garry@huawei.com>
- Cc: axboe@kernel.dk, damien.lemoal@opensource.wdc.com, bvanassche@acm.org, hch@lst.de, jejb@linux.ibm.com, martin.petersen@oracle.com, hare@suse.de, satishkh@cisco.com, sebaddel@cisco.com, kartilak@cisco.com, linux-rdma@vger.kernel.org, linux-mmc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, mpi3mr-linuxdrv.pdl@broadcom.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, nbd@other.debian.org
- Subject: Re: [PATCH 1/5] scsi: core: Remove reserved request time-out handling
- From: Christoph Hellwig <hch@lst.de>
- Date: Mon, 20 Jun 2022 07:58:28 +0200
- Message-id: <[🔎] 20220620055828.GA10192@lst.de>
- In-reply-to: <[🔎] 1655463320-241202-2-git-send-email-john.garry@huawei.com>
- References: <[🔎] 1655463320-241202-1-git-send-email-john.garry@huawei.com> <[🔎] 1655463320-241202-2-git-send-email-john.garry@huawei.com>
On Fri, Jun 17, 2022 at 06:55:16PM +0800, John Garry wrote:
> The SCSI code does not currently support reserved commands. As such,
> requests which time-out would never be reserved, and scsi_timeout()
> 'reserved' arg should never be set.
>
> Remove handling for reserved requests and drop wrapper scsi_timeout() as
> it now just calls scsi_times_out() always.
Please rename scsi_times_out to scsi_timeout so it still matches the
method name.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reply to: