[PATCH 0/2] Add data to datalog, add replay tool, V02
Hi,
Updated series. For now, only 2 changes, I'll update the rest
after review.
Patch 1: Add support for pretty-printing WRITE_ZEROS and TRIM to
nbd-trdump. I've added a 'static inline' helper function to a
new header file.
Changes:
- Support added for all commands mentioned in proto.md,
even the experimental commands.
- use #param to reduce copy/paste.
Patch 2: Add actual data logging to nbd-server
I've defined a new magic for a new request type to indicate
the new contents of the log.
Changes:
- Introduction of a new magic, and use that for a header
of the log file.
Questions:
- Should I update proto.md and declare the magic as reserved?
- I have reused the existing struct nbd_req. Is that ok, or
should I define a new structure with exactly the needed
fields?
- Should nbd-trdump abort when it encounters an unknown
flag? I would say no: It is a development tool, thus
the human reader can/must interpret the output anyways.
--
Manfred
Reply to: