Re: [PATCH] nbd: Fix hung on disconnect request if socket is closed before

To: Xie Yongji <xieyongji@bytedance.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, nbd@other.debian.org, zero.xu@bytedance.com
Subject: Re: [PATCH] nbd: Fix hung on disconnect request if socket is closed before
From: Josef Bacik <josef@toxicpanda.com>
Date: Tue, 22 Mar 2022 15:56:41 -0400
Message-id: <[🔎] Yjop+VdZi5xbHe+b@localhost.localdomain>
In-reply-to: <[🔎] 20220322080639.142-1-xieyongji@bytedance.com>
References: <[🔎] 20220322080639.142-1-xieyongji@bytedance.com>

On Tue, Mar 22, 2022 at 04:06:39PM +0800, Xie Yongji wrote:
> When userspace closes the socket before sending a disconnect
> request, the following I/O requests will be blocked in
> wait_for_reconnect() until dead timeout. This will cause the
> following disconnect request also hung on blk_mq_quiesce_queue().
> That means we have no way to disconnect a nbd device if there
> are some I/O requests waiting for reconnecting until dead timeout.
> It's not expected. So let's wake up the thread waiting for
> reconnecting directly when a disconnect request is sent.
> 
> Reported-by: Xu Jianhai <zero.xu@bytedance.com>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

Reply to:

References:
- [PATCH] nbd: Fix hung on disconnect request if socket is closed before
  - From: Xie Yongji <xieyongji@bytedance.com>

Prev by Date: Re: [PATCH] spec: Add NBD_OPT_EXTENDED_HEADERS
Next by Date: Re: [PATCH v2] nbd: Don't use workqueue to handle recv work
Previous by thread: [PATCH] nbd: Fix hung on disconnect request if socket is closed before
Next by thread: Re: [PATCH v2] nbd: Don't use workqueue to handle recv work
Index(es):
- Date
- Thread