Re: [PATCH 10/30] ps3disk: use blk_mq_alloc_disk
- To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
- Cc: Justin Sanders <justin@coraid.com>, Denis Efremov <efremov@linux.com>, Josef Bacik <josef@toxicpanda.com>, Tim Waugh <tim@cyberelk.net>, Ilya Dryomov <idryomov@gmail.com>, "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Roger Pau Monné <roger.pau@citrix.com>, Mike Snitzer <snitzer@redhat.com>, Maxim Levitsky <maximlevitsky@gmail.com>, Alex Dubov <oakad@yahoo.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, dm-devel@redhat.com, linux-block@vger.kernel.org, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org
- Subject: Re: [PATCH 10/30] ps3disk: use blk_mq_alloc_disk
- From: Geoff Levand <geoff@infradead.org>
- Date: Sun, 6 Jun 2021 08:58:41 -0700
- Message-id: <[🔎] c9d63809-a7cc-8907-6065-f14add05a5dc@infradead.org>
- In-reply-to: <[🔎] 20210602065345.355274-11-hch@lst.de>
- References: <[🔎] 20210602065345.355274-1-hch@lst.de> <[🔎] 20210602065345.355274-11-hch@lst.de>
Hi Christoph,
On 6/1/21 11:53 PM, Christoph Hellwig wrote:
> Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue
> allocation.
>
> drivers/block/ps3disk.c | 36 ++++++++++++++----------------------
> 1 file changed, 14 insertions(+), 22 deletions(-)
I tested your alloc_disk-part2 branch on PS3, and it seemed to be working OK.
Tested-by: Geoff Levand <geoff@infradead.org>
Reply to: