Re: [PATCH v3 3/8] nvme: add error handling support for add_disk()
- To: Hannes Reinecke <hare@suse.de>
- Cc: Luis Chamberlain <mcgrof@kernel.org>, axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com, hch@infradead.org, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
- Subject: Re: [PATCH v3 3/8] nvme: add error handling support for add_disk()
- From: Christoph Hellwig <hch@lst.de>
- Date: Mon, 6 Sep 2021 10:09:08 +0200
- Message-id: <[🔎] 20210906080908.GA25575@lst.de>
- In-reply-to: <[🔎] 677ca876-b003-d3b5-9e2e-d50ebef82cce@suse.de>
- References: <20210830212538.148729-1-mcgrof@kernel.org> <20210830212538.148729-4-mcgrof@kernel.org> <[🔎] 677ca876-b003-d3b5-9e2e-d50ebef82cce@suse.de>
On Mon, Sep 06, 2021 at 08:16:35AM +0200, Hannes Reinecke wrote:
> I would rather turn this around, and call 'nvme_put_ctrl()' after removing
> the namespace from the list. But it's probably more a style issue, come to
> think of it.
The order in the patch is the inverse of the order before the failure,
which generally is the right thing to do.
Reply to: