Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset

To: Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: josef@toxicpanda.com, axboe@kernel.dk, hch@lst.de, chaitanya.kulkarni@wdc.com, linux-block@vger.kernel.org, nbd@other.debian.org
Subject: Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 6 Jul 2021 06:17:18 +0200
Message-id: <[🔎] 20210706041718.GB11174@lst.de>
In-reply-to: <[🔎] 20210706040016.1360412-1-guoqing.jiang@linux.dev>
References: <[🔎] 1625477143-18716-1-git-send-email-wangqing@vivo.com> <[🔎] 20210706040016.1360412-1-guoqing.jiang@linux.dev>

On Tue, Jul 06, 2021 at 12:00:16PM +0800, Guoqing Jiang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> We must release the queue before freeing the tagset.
> 
> Fixes: 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Reply to:

References:
- [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset
  - From: Wang Qing <wangqing@vivo.com>
- [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
  - From: Guoqing Jiang <guoqing.jiang@linux.dev>

Prev by Date: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
Next by Date: Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
Previous by thread: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
Next by thread: Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
Index(es):
- Date
- Thread