[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 1/3] nbd: return -ETIMEDOUT when NBD_DO_IT ioctl returns



On 9/21/20 6:57 AM, Hou Pu wrote:
We used to return -ETIMEDOUT if io timeout happened. But since
commit d970958b2d24 ("nbd: enable replace socket if only one
connection is configured"), user space would not get -ETIMEDOUT.
This commit fixes this. Only return -ETIMEDOUT if only one socket
is configured by ioctl and the user specified a non-zero timeout
value.

Signed-off-by: Hou Pu <houpu@bytedance.com>

This is fine, you can add

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

to this one, thanks,

Josef


Reply to: