Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify
- To: Christoph Hellwig <hch@lst.de>
- Cc: Jens Axboe <axboe@kernel.dk>, Justin Sanders <justin@coraid.com>, Josef Bacik <josef@toxicpanda.com>, Ilya Dryomov <idryomov@gmail.com>, Jack Wang <jinpu.wang@cloud.ionos.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Roger Pau Monné <roger.pau@citrix.com>, Minchan Kim <minchan@kernel.org>, Mike Snitzer <snitzer@redhat.com>, Song Liu <song@kernel.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org
- Subject: Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify
- From: Petr Vorel <pvorel@suse.cz>
- Date: Thu, 12 Nov 2020 20:22:23 +0100
- Message-id: <[🔎] 20201112192223.GA17194@pevik>
- Reply-to: Petr Vorel <pvorel@suse.cz>
- In-reply-to: <20201111082658.3401686-6-hch@lst.de>
- References: <20201111082658.3401686-1-hch@lst.de> <20201111082658.3401686-6-hch@lst.de>
Hi Christoph,
> The update_bdev argument is always set to true, so remove it. Also
> rename the function to the slighly less verbose set_capacity_and_notify,
> as propagating the disk size to the block device isn't really
> revalidation.
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Nice cleanup.
Kind regards,
Petr
Reply to: