Re: remove revalidate_disk()
- To: Christoph Hellwig <hch@lst.de>
- Cc: Josef Bacik <josef@toxicpanda.com>, Dan Williams <dan.j.williams@intel.com>, dm-devel@redhat.com, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org
- Subject: Re: remove revalidate_disk()
- From: Jens Axboe <axboe@kernel.dk>
- Date: Wed, 2 Sep 2020 08:02:49 -0600
- Message-id: <[🔎] 78d5ab8a-4387-7bfb-6e25-07fd6c1ddc10@kernel.dk>
- In-reply-to: <[🔎] 20200901155748.2884-1-hch@lst.de>
- References: <[🔎] 20200901155748.2884-1-hch@lst.de>
On 9/1/20 9:57 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> this series removes the revalidate_disk() function, which has been a
> really odd duck in the last years. The prime reason why most people
> use it is because it propagates a size change from the gendisk to
> the block_device structure. But it also calls into the rather ill
> defined ->revalidate_disk method which is rather useless for the
> callers. So this adds a new helper to just propagate the size, and
> cleans up all kinds of mess around this area. Follow on patches
> will eventuall kill of ->revalidate_disk entirely, but ther are a lot
> more patches needed for that.
Applied, thanks.
--
Jens Axboe
Reply to: