Re: [PATCH 02/10] block: virtio-blk: check logical block size
- To: Christoph Hellwig <hch@lst.de>
- Cc: Maxim Levitsky <mlevitsk@redhat.com>, linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>, Josef Bacik <josef@toxicpanda.com>, "open list:BLOCK LAYER" <linux-block@vger.kernel.org>, Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>, "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>, "open list:SCSI CDROM DRIVER" <linux-scsi@vger.kernel.org>, Tejun Heo <tj@kernel.org>, Bart Van Assche <bvanassche@acm.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, Damien Le Moal <damien.lemoal@wdc.com>, Jason Wang <jasowang@redhat.com>, Maxim Levitsky <maximlevitsky@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Colin Ian King <colin.king@canonical.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Ulf Hansson <ulf.hansson@linaro.org>, Ajay Joshi <ajay.joshi@wdc.com>, Ming Lei <ming.lei@redhat.com>, "open list:SONY MEMORYSTICK SUBSYSTEM" <linux-mmc@vger.kernel.org>, Satya Tangirala <satyat@google.com>, "open list:NETWORK BLOCK DEVICE (NBD)" <nbd@other.debian.org>, Hou Tao <houtao1@huawei.com>, Jens Axboe <axboe@fb.com>, "open list:VIRTIO CORE AND NET DRIVERS" <virtualization@lists.linux-foundation.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, Alex Dubov <oakad@yahoo.com>
- Subject: Re: [PATCH 02/10] block: virtio-blk: check logical block size
- From: "Martin K. Petersen" <martin.petersen@oracle.com>
- Date: Tue, 21 Jul 2020 22:55:07 -0400
- Message-id: <[🔎] yq1zh7sfedj.fsf@ca-mkp.ca.oracle.com>
- In-reply-to: <20200721151437.GB10620@lst.de> (Christoph Hellwig's message of "Tue, 21 Jul 2020 17:14:37 +0200")
- References: <[🔎] 20200721105239.8270-1-mlevitsk@redhat.com> <[🔎] 20200721105239.8270-3-mlevitsk@redhat.com> <20200721151437.GB10620@lst.de>
Christoph,
> Hmm, I wonder if we should simply add the check and warning to
> blk_queue_logical_block_size and add an error in that case. Then
> drivers only have to check the error return, which might add a lot
> less boiler plate code.
Yep, I agree.
--
Martin K. Petersen Oracle Linux Engineering
Reply to: