[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] proto: document use of NBD_REP_ERR_PLATFORM

On 12/31/19 9:59 AM, Wouter Verhelst wrote:

When I implemented TLS support into nbd-server, I made it send
NBD_REP_ERR_PLATFORM to the client if it asked for TLS support and that
was disabled at compile time. I think this is a valid use for that error
message (which is otherwise not ever used), and I think I should update
the docs to account for it.

What do other people think?

+++ b/doc/proto.md
@@ -1582,7 +1582,8 @@ case that data is an error message string suitable for display to the user.
  * `NBD_REP_ERR_PLATFORM` (2^31 + 4)
The option sent by the client is not supported on the platform on
-    which the server is running. Not currently used.
+    which the server is running, or requires compile-time options that
+    were disabled, e.g., upon trying to use TLS.

Looks reasonable to me.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Reply to: