Re: [PATCH] nbd: prevent memory leak

To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nbd: prevent memory leak
From: Josef Bacik <josef@toxicpanda.com>
Date: Thu, 21 Nov 2019 13:30:17 -0500
Message-id: <[🔎] 20191121183017.h3qkpib5re27ty3b@MacBook-Pro-91.local>
In-reply-to: <20190923200959.29643-1-navid.emamdoost@gmail.com>
References: <20190923200959.29643-1-navid.emamdoost@gmail.com>

On Mon, Sep 23, 2019 at 03:09:58PM -0500, Navid Emamdoost wrote:
> In nbd_add_socket when krealloc succeeds, if nsock's allocation fail the
> reallocted memory is leak. The correct behaviour should be assigning the
> reallocted memory to config->socks right after success.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

Reply to:

Follow-Ups:
- Re: [PATCH] nbd: prevent memory leak
  - From: Jens Axboe <axboe@kernel.dk>

Prev by Date: Re: [PATCH] nbd: prevent memory leak
Next by Date: Re: [PATCH] nbd: prevent memory leak
Previous by thread: Re: [PATCH] nbd: prevent memory leak
Next by thread: Re: [PATCH] nbd: prevent memory leak
Index(es):
- Date
- Thread