Re: [PATCH for discussion] doc: Define a standard URI syntax for NBD URIs.
Hi Rich,
Just a few minor comments:
On Sat, May 25, 2019 at 06:05:18PM +0100, Richard W.M. Jones wrote:
> +The `userinfo` field is used to supply a username for TLS
> +authentication. If the `userinfo` field is not present then it SHOULD
> +default to a local operating system credential if one is available.
Should we perhaps also add query parameters for certificate-based authentication?
Also, I think this could be rephrased in a way that makes it clear that
usernames are not required for NBD, and that absense of them (or of a
default) is not an error.
> +It is up to the NBD client what should happen if the authority field
> +is not present for TCP/IP connections, or present for Unix domain
> +socket connections. Options might include failing with an error,
> +ignoring it, or using defaults.
[...]
> +## NBD URI query parameters
> +
> +The query part of the URI is used when connecting to Unix domain
> +sockets (when the scheme name is `nbd+unix`). In this case it MUST
> +include a `socket` key, referring to the Unix domain socket which on
> +Unix-like systems is usually a special file on the local disk.
> +
> +Query parameters other than `socket` SHOULD be ignored by the parser.
Would it be a good idea to also allow for a default Unix domain socket,
similarly to how you add a default authority field?
Other than that, LGTM.
Side note: you'll notice that I've sent you an invitation to the
NetworkBlockDevice project, so you can commit this yourself if you want
to. Please don't abuse the privilege ;-)
--
To the thief who stole my anti-depressants: I hope you're happy
-- seen somewhere on the Internet on a photo of a billboard
Reply to: