Re: [PATCH bpf-next v3 2/5] nbd: trace sending nbd requests
- To: Matt Mullins <mmullins@fb.com>
- Cc: hall@fb.com, ast@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, Daniel Borkmann <daniel@iogearbox.net>, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>, "David S. Miller" <davem@davemloft.net>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, linux-block@vger.kernel.org, nbd@other.debian.org
- Subject: Re: [PATCH bpf-next v3 2/5] nbd: trace sending nbd requests
- From: Josef Bacik <josef@toxicpanda.com>
- Date: Fri, 19 Apr 2019 17:16:01 -0400
- Message-id: <[🔎] 20190419211600.5dvflqu6ryvjgwjg@macbook-pro-91.dhcp.thefacebook.com>
- In-reply-to: <20190419210409.5021-3-mmullins@fb.com>
- References: <20190419210409.5021-1-mmullins@fb.com> <20190419210409.5021-3-mmullins@fb.com>
On Fri, Apr 19, 2019 at 02:04:06PM -0700, Matt Mullins wrote:
> This adds a tracepoint that can both observe the nbd request being sent
> to the server, as well as modify that request , e.g., setting a flag in
> the request that will cause the server to collect detailed tracing data.
>
> The struct request * being handled is included to permit correlation
> with the block tracepoints.
>
> Signed-off-by: Matt Mullins <mmullins@fb.com>
> ---
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
Reply to: