Re: [PATCH v2] doc: Define a standard URI syntax for NBD URIs.
On Tue, May 28, 2019 at 11:47:11AM -0500, Eric Blake wrote:
> On 5/28/19 5:35 AM, Richard W.M. Jones wrote:
> > For further information about discussion around this standard, see
> > this thread on the mailing list:
> > https://lists.debian.org/nbd/2019/05/msg00013.html
> >
> > Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> > ---
> > doc/Makefile.am | 2 +-
> > doc/uri.md | 183 ++++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 184 insertions(+), 1 deletion(-)
> >
>
> > +## NBD URI export name
> > +
> > +The path part of the URI except for the leading `/` character MAY be
> > +passed to the server as the export name.
> > +
> > +For example:
> > +
> > + NBD URI Export name
> > + ----------------------------------------------------
> > + nbd://example.com/disk disk
> > + nbd+unix:///disk disk
>
> Should this use:
>
> nbd+unix:///disk?socket=/foo disk
>
> to comply with the other statements that the socket query should be
> present for nbd+unix://, and to give an example of how the query is not
> part of the export name?
Yes it should - fixed in my copy.
> > +## Clients which do not support TLS
> > +
> > +Wherever this document refers to encryption, authentication and TLS,
> > +clients which do not support TLS SHOULD give an error when
> > +encountering an NBD URI that requires TLS (such as one with a scheme
> > +name `nbds`).
> > \ No newline at end of file
>
> You'll want to fix that :)
Thanks - also fixed in my copy now.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
Reply to: