RE: [PATCH fio] engines: Add Network Block Device (NBD) support.
Just a few random style comments, not a complete review...
> -----Original Message-----
> From: fio-owner@vger.kernel.org [mailto:fio-owner@vger.kernel.org] On Behalf Of Richard W.M. Jones
> Sent: Thursday, April 18, 2019 9:10 AM
> Subject: [PATCH fio] engines: Add Network Block Device (NBD) support.
>
...
> + r = getaddrinfo(hostname, port, &hints, &result);
> + if(r != 0) {
if() is not a function, so include a space.
...
> + log_err("fio: nbd: unexpected end of file "
> + "reading from server\n");
Please keep strings on one line so they can be found with grep. That's more
important than wrapping at 80 characters.
Reply to: