Re: [PATCH] block: nbd: fix a missing check for nla_nest_start

To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: nbd: fix a missing check for nla_nest_start
From: Josef Bacik <josef@toxicpanda.com>
Date: Fri, 15 Mar 2019 09:27:40 -0400
Message-id: <[🔎] 20190315132739.mfnbkp5vdjx2uhko@MacBook-Pro-91.local>
In-reply-to: <[🔎] 20190315063138.17666-1-kjlu@umn.edu>
References: <[🔎] 20190315063138.17666-1-kjlu@umn.edu>

On Fri, Mar 15, 2019 at 01:31:38AM -0500, Kangjie Lu wrote:
> nla_nest_start may fail and thus deserves a check.
> 
> The fix inserts such a check and exits gracefully in case it
> fails.
> 

Except it won't because we pre-reserve enough space for that attr.  Subsequent
calls could fail, and those are checked properly, but this one won't.  Thanks,

Josef

Reply to:

References:
- [PATCH] block: nbd: fix a missing check for nla_nest_start
  - From: Kangjie Lu <kjlu@umn.edu>

Prev by Date: [PATCH] block: nbd: fix a missing check for nla_nest_start
Next by Date: [PATCH 00/14] Convert block layer & drivers to XArray
Previous by thread: [PATCH] block: nbd: fix a missing check for nla_nest_start
Next by thread: [PATCH 00/14] Convert block layer & drivers to XArray
Index(es):
- Date
- Thread