Re: [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro
- To: axboe@kernel.dk
- Cc: ed.cashin@acm.org, philipp.reisner@linbit.com, Lars Ellenberg <lars.ellenberg@linbit.com>, Josef Bacik <josef@toxicpanda.com>, linux-block@vger.kernel.org, josh.h.morris@us.ibm.com, pjk1939@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org
- Subject: Re: [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro
- From: Frank Lee <tiny.windzz@gmail.com>
- Date: Sun, 2 Dec 2018 02:31:59 +0800
- Message-id: <[🔎] CAEExFWtJEJwgGR3gqfHDXw-c4nyA7dkQTd9fkzVsht=ROmfgMQ@mail.gmail.com>
- In-reply-to: <[🔎] 5682c419-9e44-10ed-6a2e-286e6f5c5def@kernel.dk>
- References: <[🔎] 20181201142414.7766-1-tiny.windzz@gmail.com> <[🔎] 5682c419-9e44-10ed-6a2e-286e6f5c5def@kernel.dk>
On Sun, Dec 2, 2018 at 2:11 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 12/1/18 7:24 AM, Yangtao Li wrote:
> > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > changes in v2:
> > -Modify some function names to avoid compilation errors
>
> The fact that your previous patch didn't even compile doesn't fill me
> with a lot of confidence in the amount of diligence and testing
> you apply to your patches.
>
> Why would you send something out that you didn't even compile?
>
> --
> Jens Axboe
>
These changes are the same and only require a small change.
Most of the changes are fine, so it's a bit negligent.
MBR,
Yangtao
Reply to: