Re: [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro
- To: Yangtao Li <tiny.windzz@gmail.com>, ed.cashin@acm.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, josef@toxicpanda.com, linux-block@vger.kernel.org, josh.h.morris@us.ibm.com, pjk1939@linux.vnet.ibm.com
- Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org
- Subject: Re: [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro
- From: Jens Axboe <axboe@kernel.dk>
- Date: Sat, 1 Dec 2018 11:10:58 -0700
- Message-id: <[🔎] 5682c419-9e44-10ed-6a2e-286e6f5c5def@kernel.dk>
- In-reply-to: <[🔎] 20181201142414.7766-1-tiny.windzz@gmail.com>
- References: <[🔎] 20181201142414.7766-1-tiny.windzz@gmail.com>
On 12/1/18 7:24 AM, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> changes in v2:
> -Modify some function names to avoid compilation errors
The fact that your previous patch didn't even compile doesn't fill me
with a lot of confidence in the amount of diligence and testing
you apply to your patches.
Why would you send something out that you didn't even compile?
--
Jens Axboe
Reply to: