[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Allowing > 32 bit lengths for NBD_CMD_TRIM, NBD_CMD_WRITE_ZEROES



A few questions about the proposal:

- Why must the client request NBD_INFO_BLOCK_SIZE?

- Why must the client not mix simple & structured requests?  It seems
  like a fairy arbitrary restriction, in that it doesn't make the
  client or server any easier to implement, nor does it make protocol
  analysis tools any simpler.  In fact it makes things slightly more
  complicated because it implies that there's now a hidden mode for
  each connection.

Also I'm not sure about the name "structured" request.  Why not
"large" request (and call the current one "small" request)?  The name
"structured" also implies there is some connection with this feature
and the Structured Replies feature, but AFAIK there is no connection.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


Reply to: