[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] nbd: set discard_alignment to the granularity

On 6/5/18 9:41 AM, Josef Bacik wrote:
> Technically we should be able to get away with 0 as the
> discard_alignment, but there's no way currently for the protocol to
> indicate different alignments, and in real life most disks have
> discard_alignment == discard_granularity.  Just set our alignment to our
> blocksize to make sure discards will actually work properly with 4k
> drives.

Applied, thanks.

Jens Axboe

Reply to: